Home » blogs » sneakin's blog

Today's ChangeLog

  • user warning: Table 'nolan.comments' doesn't exist query: SELECT COUNT(*) FROM comments WHERE nid = 158 AND status = 0 in /home/sneakin/web/nolan.eakins.net/includes/database.mysql.inc on line 120.
  • user warning: Table 'nolan.comments' doesn't exist query: SELECT c.cid as cid, c.pid, c.nid, c.subject, c.comment, c.format, c.timestamp, c.name, c.mail, c.homepage, u.uid, u.name AS registered_name, u.picture, u.data, c.score, c.users, c.thread, c.status FROM comments c INNER JOIN users u ON c.uid = u.uid WHERE c.nid = 158 AND c.status = 0 GROUP BY c.cid, c.pid, c.nid, c.subject, c.comment, c.format, c.timestamp, c.name, c.mail, u.picture, c.homepage, u.uid, u.name, u.picture, u.data, c.score, c.users, c.thread, c.status ORDER BY c.thread DESC LIMIT 0, 50 in /home/sneakin/web/nolan.eakins.net/includes/database.mysql.inc on line 120.
Submitted by sneakin on Tue, 2005/05/17 - 11:09.

This is mainly work under the hood. Patch 10 is hopefully a decent tradeoff in case MUC::Affiliation and MUC::Role ever get changed so as not to rely on being based on an int. Patch 9 is something that I'm proud about doing. It was a really good refactoring of a method. C2.com's MethodObject page (if it's up) helped by showing me the way.

patch-10: noticed that Role::index and Affiliation::index could return a negative

  • Created MUC::AffilMap and MUC::RoleMap
  • Changed GCUserView::Private::role_items into a map
  • Changed both AddMucOperation::name()s to use a map
  • Changed GCMainDlg::roleToString and affilToString to use a map
  • Changed AffilEditorListView::Private::affil_table into a map
  • Changed AffilEditorAddDlg::affil_table into a map

patch-9: refactored how the context menu items are added for the occupant's list

  • Created the class AddMucOperation
  • Made addMucOperation into AddMucOperation::createItem
  • Replaced calls to addMucOperation
  • Refactored each boolean variable into a AddMucOperation method
» sneakin's blog | add new comment

Ad's by Google